Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Design for Allowing Object-Level Resource Status Restore #8403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shubham-pampattiwar
Copy link
Collaborator

Thank you for contributing to Velero!

Please add a summary of your change

Design for #8204

Please indicate you've done the following:

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.38%. Comparing base (1fbd22f) to head (7442147).
Report is 197 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8403      +/-   ##
==========================================
+ Coverage   58.96%   59.38%   +0.42%     
==========================================
  Files         367      370       +3     
  Lines       38895    39987    +1092     
==========================================
+ Hits        22933    23747     +814     
- Misses      14500    14747     +247     
- Partials     1462     1493      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

@shubham-pampattiwar shubham-pampattiwar changed the title Add Design for Allowing Instance-Level Resource Status Restore Add Design for Allowing Object-Level Resource Status Restore Nov 20, 2024
Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and clear. well done!

Signed-off-by: Shubham Pampattiwar <[email protected]>

add changelog file

Signed-off-by: Shubham Pampattiwar <[email protected]>

typo fix

Signed-off-by: Shubham Pampattiwar <[email protected]>

change instance to object

Signed-off-by: Shubham Pampattiwar <[email protected]>

add precedence notes adn false as a valid anootation value

Signed-off-by: Shubham Pampattiwar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants