Add webhook framework #713
Conversation
|
I hope to push the changes commit by commit, however, the dependency is really coupled, so ... |
|
I think the doc build error is not related because it's a private repo at this moment. |
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
kerthcet
force-pushed
the
feat/add-integration-test
branch
from
550f63e to
afcfa62
Compare
Signed-off-by: kerthcet <[email protected]>
Signed-off-by: kerthcet <[email protected]>
|
Failed by TestBaseModelInferenceFailures/Invalid_API_Key, rerun. |
|
Could you take a look @Jeffwan This is the first step to introduce the webhook framework. Thanks! |
|
I was busy on the open source stuff yesterday. I will spend some time on the review todya |
|
doc build failure is expected, I switch to free version and it only supports public repo. It will come back soon |
| .PHONY: manifests | ||
| manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. | ||
| $(CONTROLLER_GEN) rbac:roleName=controller-manager-role crd:maxDescLen=0,generateEmbeddedObjectMeta=true webhook paths="./..." output:crd:artifacts:config=config/crd/bases | ||
| $(CONTROLLER_GEN) \ | ||
| rbac:roleName=controller-manager-role output:rbac:artifacts:config=config/rbac/controller-manager \ |
There was a problem hiding this comment.
In the past, we maintain this manually. some internal users want to use the component separately. so we change the folder structure to component based. If we use config/rbac/controller-manager. other components like orchestration will land into same subfolder?
There was a problem hiding this comment.
Revert since kubebuilder can't separate the roles right now, and maybe unable in a long time. I added the roles manually as well.
| @@ -81,6 +94,11 @@ vet: ## Run go vet against code. | |||
| test: manifests generate fmt vet envtest ## Run tests. | |||
| KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" go test $$(go list ./... | grep -v /e2e) -coverprofile cover.out | |||
|
|
|||
| .PHONY: test-integration | |||
|
|
||
| # Copy everything back. | ||
| cp -a "${TEMP_DIR}/${ROOT_PKG}/." "${SCRIPT_ROOT}/" | ||
| REPO_ROOT="$(git rev-parse --show-toplevel)" |
There was a problem hiding this comment.
let's have a separate PR for common tool updates? WDYT?
There was a problem hiding this comment.
I'll try to do this separately, it's related to the client-go generation.
| // +kubebuilder:default:=3 | ||
| Replicas int `json:"replicas,omitempty"` | ||
| // +optional | ||
| Replicas *int `json:"replicas,omitempty"` |
There was a problem hiding this comment.
This leads to a compile error so I changed here together, a separate PR here #740
Pull Request Description
Related Issues
xref: #710
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.