Use Data Grid density for DataGridToolbar's density
#3337
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliawegmayr
force-pushed
the
datagrid-toolbar-density
branch
from
7f61619 to
4fa334a
Compare
johnnyomair
reviewed
Feb 4, 2025
| const ownerState: OwnerState = { | ||
| density, | ||
| density: gridDensity || density, |
There was a problem hiding this comment.
This fallback won't work because you provide a fall back in L61
.changeset/large-moons-kiss.md
Outdated
|
|
||
| Deprecate `density` prop of `DataGridToolbar` | ||
|
|
||
| The usage of the `density` prop in `DataGridToolbar` is now deprecated as DataGrid now controls the styling of DataGridToolbar based on its density setting. |
There was a problem hiding this comment.
Suggested change
| The usage of the `density` prop in `DataGridToolbar` is now deprecated as DataGrid now controls the styling of DataGridToolbar based on its density setting. | |
| The density setting of the surrounding Data Grid now controls the styling of the toolbar. |
johnnyomair
changed the title
DataGridToolbar's density
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment it is necessary to pass the density prop twice: once to the DataGrid and once to the DataGridToolbar.
The DataGridToolbar should not get the prop anymore, but instead use the density of the DataGrid.
Acceptance criteria
Screenshots/screencasts
Standard:
Compact:
Comfortable:
Open TODOs/questions
Further information