-
Notifications
You must be signed in to change notification settings - Fork 57
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #573 from vitessio/refactor-compare
Refactor Compare Page
- Loading branch information
Showing
10 changed files
with
686 additions
and
134 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,219 @@ | ||
| /* | ||
| Copyright 2024 The Vitess Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| import { Badge } from "@/components/ui/badge"; | ||
| import { | ||
| Table, | ||
| TableBody, | ||
| TableCell, | ||
| TableHead, | ||
| TableHeader, | ||
| TableRow, | ||
| } from "@/components/ui/table"; | ||
| import { | ||
| Tooltip, | ||
| TooltipContent, | ||
| TooltipProvider, | ||
| TooltipTrigger, | ||
| } from "@/components/ui/tooltip"; | ||
| import { MacroDataValue, Range } from "@/types"; | ||
| import { | ||
| fixed, | ||
| formatByte, | ||
| formatGitRef, | ||
| secondToMicrosecond, | ||
| } from "@/utils/Utils"; | ||
| import { Link } from "react-router-dom"; | ||
|
|
||
| type MacroBenchmarkTableDataRow = { | ||
| title: string; | ||
| old: MacroDataValue; | ||
| new: MacroDataValue; | ||
| p: number; | ||
| delta: number; | ||
| insignificant: boolean; | ||
| }; | ||
|
|
||
| export type MacroBenchmarkTableData = { | ||
| qpsTotal: MacroBenchmarkTableDataRow; | ||
| qpsReads: MacroBenchmarkTableDataRow; | ||
| qpsWrites: MacroBenchmarkTableDataRow; | ||
| qpsOther: MacroBenchmarkTableDataRow; | ||
| tps: MacroBenchmarkTableDataRow; | ||
| latency: MacroBenchmarkTableDataRow; | ||
| errors: MacroBenchmarkTableDataRow; | ||
| totalComponentsCpuTime: MacroBenchmarkTableDataRow; | ||
| vtgateCpuTime: MacroBenchmarkTableDataRow; | ||
| vttabletCpuTime: MacroBenchmarkTableDataRow; | ||
| totalComponentsMemStatsAllocBytes: MacroBenchmarkTableDataRow; | ||
| vtgateMemStatsAllocBytes: MacroBenchmarkTableDataRow; | ||
| vttabletMemStatsAllocBytes: MacroBenchmarkTableDataRow; | ||
| }; | ||
|
|
||
| export type MacroBenchmarkTableProps = { | ||
| data: MacroBenchmarkTableData; | ||
| oldGitRef: string; | ||
| newGitRef: string; | ||
| }; | ||
|
|
||
| const getDeltaBadgeVariant = (key: string, delta: number, p: number) => { | ||
| if (delta === 0) { | ||
| return "warning"; | ||
| } | ||
| if ( | ||
| key.includes("CpuTime") || | ||
| key.includes("Mem") || | ||
| key.includes("latency") | ||
| ) { | ||
| if (delta < 0) { | ||
| return "success"; | ||
| } | ||
| } | ||
| if (key.includes("qps") || key.includes("tps")) { | ||
| if (delta > 0) { | ||
| return "success"; | ||
| } | ||
| } | ||
| return "destructive"; | ||
| }; | ||
|
|
||
| const formatCellValue = (key: string, value: number) => { | ||
| if (key.includes("CpuTime")) { | ||
| return secondToMicrosecond(value); | ||
| } else if (key.includes("MemStatsAllocBytes")) { | ||
| return formatByte(Number(fixed(value, 2))); | ||
| } | ||
| return fixed(value, 2); | ||
| }; | ||
|
|
||
| export function getRange(range: Range) { | ||
| if (range.infinite == true) { | ||
| return "∞"; | ||
| } | ||
| if (range.unknown == true) { | ||
| return "?"; | ||
| } | ||
| return "±" + fixed(range.value, 1) + "%"; | ||
| } | ||
|
|
||
| // Type-safe function to access properties | ||
| const getValue = <T, K extends keyof T>(obj: T, key: K): T[K] => obj[key]; | ||
|
|
||
| export default function MacroBenchmarkTable({ | ||
| data, | ||
| newGitRef, | ||
| oldGitRef, | ||
| }: MacroBenchmarkTableProps) { | ||
| if (!data) { | ||
| return null; | ||
| } | ||
| const dataKeys = Object.keys(data) as Array<keyof MacroBenchmarkTableData>; | ||
|
|
||
| // Use keyof MacroBenchmarkTableData to enforce key types | ||
| const classNameMap: { [key in keyof MacroBenchmarkTableData]: string } = { | ||
| qpsTotal: "border-b border-foreground dark:border-none", | ||
| qpsReads: "bg-muted/80", | ||
| qpsWrites: "bg-muted/80", | ||
| qpsOther: "bg-muted/80 border-b border-foreground dark:border-none", | ||
| tps: "bg-background", | ||
| latency: "bg-background", | ||
| errors: "bg-background", | ||
| totalComponentsCpuTime: "border-b border-foreground dark:border-none", | ||
| vtgateCpuTime: "bg-muted/80 ", | ||
| vttabletCpuTime: "bg-muted/80 border-b border-foreground dark:border-none", | ||
| totalComponentsMemStatsAllocBytes: | ||
| "border-b border-foreground dark:border-none", | ||
| vtgateMemStatsAllocBytes: "bg-muted/80", | ||
| vttabletMemStatsAllocBytes: | ||
| "bg-muted/80 border-b border-foreground dark:border-none", | ||
| }; | ||
|
|
||
| return ( | ||
| <Table> | ||
| <TableHeader> | ||
| <TableRow className="hover:bg-background border-b"> | ||
| <TableHead className="w-[200px]"></TableHead> | ||
| <TableHead className="text-center text-primary font-semibold"> | ||
| <Link | ||
| to={`https://github.com/vitessio/vitess/commit/${oldGitRef}`} | ||
| target="__blank" | ||
| > | ||
| {formatGitRef(oldGitRef) || "N/A"} | ||
| </Link> | ||
| </TableHead> | ||
| <TableHead className="text-center text-primary font-semibold"> | ||
| <Link | ||
| to={`https://github.com/vitessio/vitess/commit/${newGitRef}`} | ||
| target="__blank" | ||
| > | ||
| {formatGitRef(newGitRef) || "N/A"} | ||
| </Link>{" "} | ||
| </TableHead> | ||
| <TableHead className="lg:w-[150px] text-center font-semibold">P</TableHead> | ||
| <TableHead className="lg:w-[150px] text-center font-semibold">Delta</TableHead> | ||
| </TableRow> | ||
| </TableHeader> | ||
| <TableBody> | ||
| {dataKeys.map((key, index) => { | ||
| const row = getValue(data, key); | ||
| return ( | ||
| <TableRow key={index} className={classNameMap[key]}> | ||
| <TableCell className="w-[200px] font-medium text-right border-r border-border"> | ||
| {row.title} | ||
| </TableCell> | ||
| <TableCell className="text-center text-front"> | ||
| {formatCellValue(key, Number(row.old.center))} ( | ||
| {getRange(row.old.range)}) | ||
| </TableCell> | ||
| <TableCell className="text-center text-front border-r border-border"> | ||
| {formatCellValue(key, Number(row.new.center))} ( | ||
| {getRange(row.new.range)}) | ||
| </TableCell> | ||
| <TableCell className="lg:w-[150px] text-center text-front"> | ||
| <TooltipProvider delayDuration={200}> | ||
| <Tooltip> | ||
| <TooltipTrigger asChild> | ||
| <div> | ||
| <Badge | ||
| variant={row.p > 0.05 ? "destructive" : "success"} | ||
| > | ||
| {fixed(row.p, 3)} | ||
| </Badge> | ||
| </div> | ||
| </TooltipTrigger> | ||
| <TooltipContent> | ||
| <p> | ||
| {row.insignificant ? "Insignificant" : "Significant"} | ||
| </p> | ||
| </TooltipContent> | ||
| </Tooltip> | ||
| </TooltipProvider> | ||
| </TableCell> | ||
| <TableCell className="lg:w-[150px] text-center text-front"> | ||
| {row.insignificant && <>{fixed(row.delta, 3)}%</>} | ||
| {!row.insignificant && ( | ||
| <Badge variant={getDeltaBadgeVariant(key, row.delta, row.p)}> | ||
| {fixed(row.delta, 3)}% | ||
| </Badge> | ||
| )} | ||
| </TableCell> | ||
| </TableRow> | ||
| ); | ||
| })} | ||
| </TableBody> | ||
| </Table> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.