Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove output size checks from verify_coinbase #400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove output size checks from verify_coinbase #400

wants to merge 1 commit into from

Conversation

JoseSK999
Copy link
Contributor

We forgot removing this check (coinbase output scripts, like any other, can be >10KB).

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other:

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other: .

@JoseSK999
Remove output size checks from verify_coinbase
95a5a66 
We forgot removing this check.
@Davidson-Souza
Copy link
Collaborator

Davidson-Souza commented Mar 7, 2025 •
edited
Loading

Oh, right. An oversized coinbase output can be created. But it can never be spent. Nice catch!

ACK 95a5a66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoseSK999 @Davidson-Souza