wire: make all nodes reply to user requests #399
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, only the running_node could reply to user request. However, that's cumbersome and limiting. After this commit, both sync_node and chain_selector can handle user requests made from the handle.
Davidson-Souza
added
enhancement
jaoleal
approved these changes
Mar 7, 2025
| } | ||
| } | ||
|
|
||
| pub(crate) async fn check_is_user_block_and_reply( |
There was a problem hiding this comment.
/// Check if this block request is made by a user through the user interface and answer it back to the
/// user if so.
///
/// This function will return the given block if isnt.
| ); | ||
| } | ||
|
|
||
| async fn perform_user_request(&mut self, user_req: Vec<UserRequest>) { |
There was a problem hiding this comment.
/// This function executes user requests pacing it against inflights requests.
| Ok(()) | ||
| } | ||
|
|
||
| fn handle_get_peer_info(&self) { |
There was a problem hiding this comment.
/// Executes all getpeerinfo user requests.
| self.user_requests.clone() | ||
| } | ||
|
|
||
| pub(crate) async fn handle_user_request(&mut self) -> Result<(), WireError> { |
There was a problem hiding this comment.
/// Wrapper/Helper function that iterate over all user_requests and pass it to perform_user_request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Until now, only the running_node could reply to user request. However, that's cumbersome and limiting. After this commit, both sync_node and chain_selector can handle user requests made from the handle.
Checklist
just lintcargo test