Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: also install floresta-cli to path #374

Closed
wants to merge 1 commit into from
Closed

build: also install floresta-cli to path #374

wants to merge 1 commit into from

Conversation

luisschwab
Copy link
Contributor

What is the purpose of this pull request?

  • Bug fix
  • Documentation update
  • New feature
  • Test
  • Other: build

Which crates are being modified?

  • floresta-chain
  • floresta-cli
  • floresta-common
  • floresta-compact-filters
  • floresta-electrum
  • floresta-watch-only
  • floresta-wire
  • floresta
  • florestad
  • Other:

Description

cargo install --path ./florestad now also installs floresta-cli to the path

Notes to the reviewers

N/A

Checklist

  • I've signed all my commits
  • I ran just lint
  • I ran cargo test
  • I've checked the integration tests
  • I've followed the contribution guidelines
  • I'm linking the issue being fixed by this PR (if any)

@jaoleal
Copy link
Contributor

jaoleal commented Feb 15, 2025

ACK

@luisschwab luisschwab force-pushed the build/install-floresta-cli branch from d9b952d to c1c2947 Compare February 17, 2025 04:42
@luisschwab luisschwab closed this Feb 17, 2025
@luisschwab
Copy link
Contributor Author

Closed in favor of #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davidson-Souza Davidson-Souza Davidson-Souza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisschwab @jaoleal @Davidson-Souza