More metrics #372
Merged
More metrics #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseSK999
suggested changes
Feb 13, 2025
This metric returns the an average of how long does it take to validate a single block. The average is computed in as a rolling fraction that keeps a sum of the elements with a denomator telling how many blocks we've checked. To get the average, simply dive the two and get a normal arithmetic mean, in seconds.
This histogram will show how long peers are taking to reply our messages, in seconds
Davidson-Souza
force-pushed
the
more-metrics
branch
from
a462f7f to
9d10c9b
Compare
|
Nice, ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Add a few new metrics endpoints for prometheus: number of peers, average time to validate a block and a histogram for peer latency
Notes to the reviewers
Each commit fully implements one metric
Checklist
just lintcargo test