Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fuzz testing to ci-cd #353

Merged

Conversation

erickcestari
Copy link
Contributor

What is this PR for?

This PR introduces automated fuzz testing to the CI/CD pipeline. Every pull request or push to the master branch will trigger all the fuzz tests located in the floresta-fuzz directory.

What is the purpose of this pull request?

  • Bug fix;
  • New feature;
  • Docs update;
  • Test;
  • Other: .

Which aspect of floresta its being addresed?

  • Blockchain;
  • Nodes communication;
  • User consumption;
  • Utreexo accumulator;
  • Other: .

Checklists

  • I've signed all my commits;
  • I ran just lint;
  • I ran cargo test;
  • I checked the integration tests;
  • I'm linking the issue being fixed by this PR (if any).

Description

This PR addresses the addition of fuzz testing to the CI/CD pipeline, as outlined in issue #350. The goal is to enhance the robustness and reliability of the codebase by automatically running fuzz tests on every PR and push to the master branch.

Notes to the reviewers

  • Why Fuzz Testing?

Fuzz testing is a powerful technique to uncover edge cases and potential vulnerabilities by providing random, invalid, or unexpected inputs to the system. Integrating it into the CI/CD pipeline ensures that these tests are run consistently, catching issues early in the development process.

  • Implementation Details:

The fuzz tests are located in the floresta-fuzz directory. The CI/CD pipeline has been updated to include a step that triggers these tests automatically.

  • Impact:

This change should not affect the existing functionality of the codebase but will help in identifying and fixing potential issues before they reach production.

@erickcestari erickcestari changed the title add fuzz testing in ci-cd add fuzz testing to ci-cd Jan 25, 2025
Copy link
Collaborator

@Davidson-Souza Davidson-Souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK.

I think this should have dep caching like the other CI jobs we have

.github/workflows/fuzz.yml Outdated Show resolved Hide resolved
@erickcestari erickcestari force-pushed the add-fuzz-testing-ci-cd branch from 82f8ceb to 31ad399 Compare January 27, 2025 14:24
@erickcestari
Copy link
Contributor Author

@Davidson-Souza I’ve added caching to the most critical parts. If you need any adjustments or have suggestions, feel free to let me know.

Also, it would be great if @brunoerg could review this—he might spot some good areas for improvement.

@brunoerg
Copy link
Contributor

brunoerg commented Feb 3, 2025

Concept ACK

.github/workflows/fuzz.yml Outdated Show resolved Hide resolved
@brunoerg
Copy link
Contributor

brunoerg commented Feb 3, 2025

You can squash the commits.

every pr or push to master will trigger all the fuzz testing located on
floresta-fuzz

change branch main to master

add dep caching

use actions upload artifact v4 instead of v3 which is deprecated

change each target time to 1 minute
@erickcestari erickcestari force-pushed the add-fuzz-testing-ci-cd branch from 90ef05f to 35b7729 Compare February 3, 2025 14:20
@Davidson-Souza
Copy link
Collaborator

ACK 35b7729

I ran this on my own fork and it works fine.

Copy link
Contributor

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 35b7729

@Davidson-Souza Davidson-Souza merged commit 00b3f5b into vinteumorg:master Feb 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants