Feat: Create some very basic mempool stuff #346
Merged
+1,276
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidson-Souza
force-pushed
the
mempool-acc
branch
2 times, most recently
from
9c06b93 to
42e116b
Compare
|
Note: The CI error will be fixed after mit-dci/rustreexo#65 gets merged and I update the dependency to either |
Davidson-Souza
force-pushed
the
mempool-acc
branch
from
42e116b to
000ba19
Compare
jaoleal
reviewed
Feb 5, 2025
|
This mempool feature have already a big diff. IMO you could put this changes on a branch so others(me?) can help you and have a proper mempool branch for testing before merging it. |
|
Agree, I'd also help with review and implementation as this is a requirement for the |
I will make this for the next patches. I would like to get this on master because we can use this into our functional tests see #252 (comment) |
This commit adds a partial forest to mempool, and the ability to verify proofs.
Now, if you call `get_block_proof` for a block whose outputs we have in our mempool, we'll get a proof for it. This commit also adds some tests for mempool stuff
Davidson-Souza
force-pushed
the
mempool-acc
branch
from
000ba19 to
5ead3e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now check proofs for unconfirmed transactions, cache them and create blocks. However, we won't ask for peers to send transactions for now.