update command

Signed-off-by: vietanhduong <[email protected]>
vietanhduong · Jun 1, 2023 · 4e81290 · 4e81290
1 parent dda5646
commit 4e81290
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 7 deletions.
diff --git a/cmd/gke/refresh/cmd.go b/cmd/gke/refresh/cmd.go
@@ -33,6 +33,7 @@ Refresh all worker nodes in all node pools of the input cluster. This command ju
 
 	cmd.Flags().StringVarP(&runCfg.location, "location", "l", "asia-southeast1", "the cluster location")
 	cmd.Flags().StringVarP(&runCfg.project, "project", "p", "", "the project where contain the cluster")
+	cmd.Flags().BoolVar(&runCfg.recreate, "recreate", false, "keep the instance (node) name or delete and create with new name otherwise")
 
 	return cmd
 }
diff --git a/cmd/gke/refresh/run.go b/cmd/gke/refresh/run.go
@@ -10,6 +10,7 @@ type runConfig struct {
 	name     string
 	project  string
 	location string
+	recreate bool
 }
 
 func run(cfg runConfig) error {
@@ -20,7 +21,7 @@ func run(cfg runConfig) error {
 	if cluster == nil {
 		return errors.Errorf("cluster '%s/%s/%s' not found", cfg.project, cfg.location, cfg.name)
 	}
-	if err = gke.RefreshCluster(cluster); err != nil {
+	if err = gke.RefreshCluster(cluster, cfg.recreate); err != nil {
 		return err
 	}
 	log.Printf("INFO: cluster '%s' has been refreshed!", cfg.name)

diff --git a/cmd/vm/pause/cmd.go b/cmd/vm/pause/cmd.go
@@ -33,5 +33,6 @@ This command require '--zone' and '--project' flags.`,
 
 	cmd.Flags().StringVarP(&runCfg.zone, "zone", "z", "asia-southeast1-b", "the instance's zone")
 	cmd.Flags().StringVarP(&runCfg.project, "project", "p", "", "the project where contain the instance")
+	cmd.Flags().BoolVar(&runCfg.terminate, "terminate", false, "terminate the instance or suspend otherwise")
 	return cmd
 }
diff --git a/cmd/vm/pause/run.go b/cmd/vm/pause/run.go
@@ -7,9 +7,10 @@ import (
 )
 
 type runConfig struct {
-	project string
-	zone    string
-	name    string
+	project   string
+	zone      string
+	name      string
+	terminate bool
 }
 
 func run(cfg runConfig) error {
@@ -21,7 +22,7 @@ func run(cfg runConfig) error {
 		return errors.Errorf("instance '%s/%s/%s' not found", cfg.project, cfg.zone, cfg.name)
 	}
 
-	if err = vm.StopInstance(instance, false); err != nil {
+	if err = vm.StopInstance(instance, cfg.terminate); err != nil {
 		return err
 	}
 	log.Printf("INFO: instance %s has been stopped!", instance.GetName())

diff --git a/pkg/gcloud/gke/gke.go b/pkg/gcloud/gke/gke.go
@@ -272,7 +272,7 @@ type instanceGroup struct {
 	IsManaged string `json:"isManaged,omitempty"`
 }
 
-func RefreshCluster(cluster *apis.Cluster) error {
+func RefreshCluster(cluster *apis.Cluster, recreate bool) error {
 	var refresh = func(project string, ig instanceGroup) error {
 		if ig.IsManaged != "Yes" {
 			log.Printf("INFO: instance group %s has been ignored becase it's not managed\n", ig.Name)
@@ -285,6 +285,11 @@ func RefreshCluster(cluster *apis.Cluster) error {
 			location = ig.Region
 		}
 
+		var replaceMethod = "substitute"
+		if recreate {
+			replaceMethod = "recreate"
+		}
+
 		_, err := exec.Run(exec.Command("gcloud",
 			"compute",
 			"instance-groups",
@@ -294,7 +299,7 @@ func RefreshCluster(cluster *apis.Cluster) error {
 			ig.Name,
 			"--project", project,
 			locationFlag, location,
-			"--replacement-method", "recreate",
+			"--replacement-method", replaceMethod,
 			"--max-surge", "0",
 			"--max-unavailable", "1"))
 		if err != nil {