Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom_http_statuses #21

Closed
wants to merge 3 commits into from

Conversation

yktakaha4
Copy link

ref: louy#89

Added test to PR submitted to louy/terraform-provider-uptimerobot.
It is a very good fix and I hope it will be merged.

In my local:

$ TF_ACC=1 go test -v ./... -run TestUptimeRobotDataResourceMonitor_custom_http_statuses
?       github.com/vexxhost/terraform-provider-uptimerobot      [no test files]
=== RUN   TestUptimeRobotDataResourceMonitor_custom_http_statuses
2022/09/06 20:39:55 [DEBUG] POST https://api.uptimerobot.com/v2/newMonitor
2022/09/06 20:39:58 [DEBUG] POST https://api.uptimerobot.com/v2/getMonitors
2022/09/06 20:40:00 [DEBUG] POST https://api.uptimerobot.com/v2/getMonitors
2022/09/06 20:40:04 [DEBUG] POST https://api.uptimerobot.com/v2/getMonitors
2022/09/06 20:40:06 [DEBUG] POST https://api.uptimerobot.com/v2/deleteMonitor
2022/09/06 20:40:07 [DEBUG] POST https://api.uptimerobot.com/v2/getMonitors
--- PASS: TestUptimeRobotDataResourceMonitor_custom_http_statuses (15.61s)
PASS
ok      github.com/vexxhost/terraform-provider-uptimerobot/internal/provider    15.622s
?       github.com/vexxhost/terraform-provider-uptimerobot/internal/provider/api        [no test files]

@yktakaha4 yktakaha4 closed this Oct 27, 2022
@yktakaha4
Copy link
Author

merged: lapras-inc#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants