-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add manila csi #80
Conversation
In addition, deploy cinder-csi plugin as conditional
d3d94a9
to
30691e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mnaser i added comments where requires more attention.
magnum_cluster_api/manifests/manila-csi/csi-controllerplugin.yaml
Outdated
Show resolved
Hide resolved
magnum_cluster_api/manifests/manila-csi/csi-controllerplugin.yaml
Outdated
Show resolved
Hide resolved
@okozachenko1203 I previously built a tool here which will 'sync' all the manifests and apply all the changes that we use -- https://github.com/vexxhost/magnum-cluster-api/blob/main/tools/sync-csi-manifests There are other sync jobs too. I think what I would like is that maybe we extend that script, and we also create a job that runs this script in CI and uses git to make sure that no changes happen, which means that no one made changes that were not implmented in this script and we can 'reliabely' get the manifests by running that script. The potential second step to this is adding this script into the build script so that the manifestis not bundled in the source code but added in build time like we do for charts. |
I think we can consider keeping diff/patch files instead of writing py script. |
- set the namespace in namespace-scoped resources' metadata - set the namespace in subjets of role binding resources
magnum.conf
by adding[manila_client]
section for keystone authtoken. So magnum driver can configure manila_client and use this to interact with sharev2 api.magnum
doesn't supportmanila
intergration so I overridemagnum.common.clients.OpenStackClients
to includemanila
method which returns the manila client.cinder_csi_enabled
,manila_csi_enabled
) are set astrue
, if the underlying openstack has no enabled endpoints for cinder and manila, it will not install those plugins.fix: #79