Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MCAPI-57] feat: ensure the cluster upgrade follows the minor/patch upgrade rule #484

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[MCAPI-57] feat: ensure the cluster upgrade follows the minor/patch upgrade rule #484

wants to merge 2 commits into from

Conversation

okozachenko1203
Copy link
Member

No description provided.

mnaser
mnaser requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this cluster end up in a UPDATE_FAILED state? :(

@okozachenko1203
Copy link
Member Author

Wouldn't this cluster end up in a UPDATE_FAILED state? :(

yes, it'll end up in a failed state.

There are 2 ways to reject update operation keeping the cluster status unchanged.

  • add version check in magnum project instead of mcapi
  • raise exception.NotSupported inside mcapi. it will be detected in magnum conductor but the cluster status will be unchanged

https://opendev.org/openstack/magnum/src/commit/1c3d7d070b60a36ccfb7c753b26f12609d818cec/magnum/conductor/handlers/cluster_conductor.py#L337-L354

@okozachenko1203
Copy link
Member Author

I went with the latter option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaser mnaser Awaiting requested review from mnaser

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okozachenko1203 @mnaser