feat: Add insecure_registry_url label option & Update containerd sett… #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @harunalbayrak ! Thanks for your contribution. The Magnum API seems to ship |
You are welcome @mnaser. The Magnum API ships insecure_registry as an attribute but it works only with docker. So, Magnum API doesn't handle config.toml file which is used in containerd. Since containerd is used in Cluster API, the insecure_registry attribute doesn't work. I thought that it was the best solution for this situation. Do you have any advice? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding insecure_registry_url label and Updating containerd settings to download the images with an insecure registry.