Add pool identification by output address #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks the outputs of the transaction for known pool addresses specified in addresses.json. Returns P2Pool is there are more than 1 output addresses in the transaction.
Cubey2019
reviewed
Mar 15, 2018
| "address": "VpYQTF5W927YRNxP9osKTTqH3qi8R2r4sB", | ||
| "url": "http://coinotron.com" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Can't the address field be added to pools.json, to avoid having 2 separate pool lists to maintain?
Also might be worth changing the address field to an array of addresses -- didn't Coinotron used to have a different address? (VuPp8H4W3g1dmwGg6pe41D2Khw8JvfEznn?)
Cubey2019
reviewed
Mar 15, 2018
| @@ -350,6 +360,10 @@ BlockController.prototype.getPoolInfo = function(tx) { | |||
| } | |||
| } | |||
|
|
|||
| if (tx.outputs.length > 1) { | |||
| return { "poolName": "P2Pool", "url": "https://vertcoin.org" }; | |||
There was a problem hiding this comment.
This is probably correct but IMO doesn't feel right to assume that multiple outputs must be P2Pool. I'm not sure if there's any other way to detect a P2Pool block though (@metalicjames it would be useful if P2Pool would put something in the coinbase like other pools)
It would be nice to be able to configure the pool name & url from pools.json somehow, maybe something like this could work?
{
"poolName": "P2Pool",
"url": "https://scanner.vertcoin.org",
"hasManyOutputs": true
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks the outputs of the transaction for known pool addresses specified
in addresses.json. Returns P2Pool is there are more than 1 output
addresses in the transaction.