(statsig-adapter): Move Edge Config to peer deps, more consistent api key naming #43
+329
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
dferber90
reviewed
Jan 21, 2025
| "peerDependencies": { | ||
| "@vercel/edge-config": "~1.2.0", | ||
| "statsig-node-vercel": "~0.4.0" | ||
| }, |
There was a problem hiding this comment.
You can further add this to mark the dependencies as optional
"peerDependenciesMeta": {
"@vercel/edge-config": {
"optional": true
},
"statsig-node-vercel": {
"optional": true
}
},
This way people not using Edge Config won't get warnings
AAorris
force-pushed
the
statsig-adapter
branch
from
3f9ef69 to
0dd8420
Compare
…), add origin, add exposure logging option
…ntation of the Statsig adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Statsig has
client | server | consoleapi keys. We can shore up the naming withstatsig,[type], andapi key. Use this convention across the adapter.Move Edge Config related dependencies to peer dependencies and dynamically import them when used, so that the flags SDK can be used without including Vercel if it's not needed.
Constrain the package.json requests to the major version, and let the app pin versions if desired