Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Convert cookie attribute "sameSite" of TRUE to "strict" as per documentation #1078

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Heinrich-Barth
Copy link

This PR addresses the following issue:

Per documentation, the cookie attribute sameSite should convert the boolean value of "true" to "strict".

This is not the case. Instead, a cookie will have an invalid value, e.g.

session=anyvalue; Path=/; SameSite=true

expected cookie String should (per documentation) should be

session=anyvalue; Path=/; SameSite=strict

This patch converts the boolean true to "strict" as per documentation.

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 9f1a466

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 9, 2025

@Heinrich-Barth is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant