Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Address Regex to Allow Uppercase Hex Characters #312

Closed
wants to merge 1 commit into from

Conversation

kyleboe
Copy link
Contributor

@kyleboe kyleboe commented Jan 12, 2025

This will allow people to submit checksum versions of their contract address.

i.e. 0x24Ee6E8D0ffCcA3D73EADA5c8585301F2BC10d60 == 0x24ee6e8d0ffcca3d73eada5c8585301f2bc10d60

Both are equally reachable.

@kyleboe
Copy link
Contributor Author

kyleboe commented Jan 12, 2025

Related to the headache in #310

@libotony
Copy link
Member

@kyleboe Thank you for the contribution, the lowercased address is intended as a feature. Reason for that is original format is enough for submitting the application, other application use this as a source can freely choose to display either checksum-ed or original address.

If you feel strong on this, I would suggest the PR to be enforce contract address to be checksum-ed.

@kyleboe
Copy link
Contributor Author

kyleboe commented Jan 15, 2025

That makes sense. It just wasn't obvious from the documentation. Thanks for the insight into the reasoning!

EDIT: never mind. I'm a doofus. I see now that it's in big bold letters in the Readme lol. Thanks for bearing with my lack of attentiveness

@kyleboe kyleboe closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants