static: remove -Wl,--no-undefined from ldflags. Go 1.17 will have sup… #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port for linking with LLVM lld, but LLD its self doesn't accept --no-undefined
|
Hi @Keithcat1, thanks for submitting the pull request! Could you explain why we need to remove the flag? Is Go going to use LLD as the default linker? If so, could you please share the links? Otherwise, perhaps this can be implemented via a build tag? |
|
LLD won't become the default linker for GO as far as I know, however I like to use it because it speeds up compilation times. |
|
Ahh I see. If @gen2brain said it's okay, then I will merge this pull request. Thanks for bringing the old issue back into attention! I will also back-port this back to v0.4.x. |
veeableful
pushed a commit
that referenced
this pull request
May 8, 2021
…port for linking with LLVM lld, but LLD its self doesn't accept --no-undefined (#481)
neputevshina
pushed a commit
to neputevshina/go-sdl2
that referenced
this pull request
Nov 13, 2024
…port for linking with LLVM lld, but LLD its self doesn't accept --no-undefined (veandco#481)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…port for linking with LLVM lld, but LLD its self doesn't accept --no-undefined