feat(xo-web/new/sr): ability to select NFS version #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
reviewed
Jun 14, 2019
| onChange={this._handleNfsVersion} | ||
| value={nfsVersion} | ||
| > | ||
| <option value={null}> |
There was a problem hiding this comment.
I don't think null is a valid value for HTML's select.
GHEMID-Mohamed
requested review from
Rajaa-BARHTAOUI
and removed request for
Rajaa-BARHTAOUI
GHEMID-Mohamed
force-pushed
the
select-nfs-version
branch
from
67d6068 to
d2951f6
Compare
Rajaa-BARHTAOUI
approved these changes
Jun 18, 2019
pdonias
approved these changes
Jun 19, 2019
|
Please update the screenshot and if you don't plan to add any documentation for this, you can check "documentation updated". |
pdonias
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3951
Fixes #007)CHANGELOG.unreleased.md:${name} v${new version})