Fix jobs being retried forever

[wfltaylor]

Currently, if a job is dispatched with a non-zero maxRetryCount, the job is retried forever. This is because the JobData was initialised with the default value (0) for attempts.

I’ve added a test for this, however it is currently flakey (especially when run with SQLite) since delayUntil is set for retried jobs, even if the retry delay is zero. This can be fixed by changing the behaviour in the queues package to set a nil delayUntil when the retry delay is zero, but I’m not sure if this is the best solution.

[gwynne]

Nice catch, thanks for this! As regards the flaky test, if I'm reading the code correctly (such that it's failing because the retry attempt comes so quickly that the check for the job delay doesn't pass?) you could make it reliable by .run()-ing the worker multiple times (in this case, 6). You're right about the real solution being to fix the behavior in queues itself, though, and your suggested fix looks correct to me - if you're up for opening a PR to do that, I'd gladly accept it along with this one 🙂.

[wfltaylor]

Nice catch, thanks for this! As regards the flaky test, if I'm reading the code correctly (such that it's failing because the retry attempt comes so quickly that the check for the job delay doesn't pass?) you could make it reliable by .run()-ing the worker multiple times (in this case, 6). You're right about the real solution being to fix the behavior in queues itself, though, and your suggested fix looks correct to me - if you're up for opening a PR to do that, I'd gladly accept it along with this one 🙂.

The reason the SQLite test was so “flakey” was because jobs with a delay_until value are never executed 🙂. I’ve created another PR which should address this issue: #16

I also created a PR to change the behaviour for setting delayUntil in Queues as well, since I do think this makes sense: vapor/queues#140

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (f302c45) to head (b42a2c6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files           7        7           
  Lines         275      275           
=======================================
  Hits          270      270           
  Misses          5        5           

Files with missing lines	Coverage Δ
Sources/QueuesFluentDriver/FluentQueue.swift	96.93% <100.00%> (ø)

[gwynne]

Holding off on merging temporarily until we get the release automation working (won't take long).