Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isMobilePhone): Add Monaco [fr-MC] mobile phone validation #2472

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat(isMobilePhone): Add Monaco [fr-MC] mobile phone validation #2472

wants to merge 5 commits into from

Conversation

theos0x
Copy link

@theos0x theos0x commented Oct 11, 2024

Description

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

rubiin
rubiin requested changes Oct 12, 2024
View reviewed changes
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turn off formatter. seems to be causing many edits which are not part of pr

@theos0x
Copy link
Author

theos0x commented Oct 12, 2024

Turn off formatter. seems to be causing many edits which are not part of pr

@rubiin thanks for the comment, it's been updated now, can you check?

@theos0x theos0x requested a review from rubiin October 12, 2024 17:49
@theos0x
Copy link
Author

theos0x commented Oct 16, 2024

@rubiin @profnandaa hi, can you check changes ?

rubiin
rubiin previously approved these changes Nov 12, 2024
View reviewed changes
WikiRik
WikiRik requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to official sources like https://www.itu.int/oth/T020200008D/en for a better RegEx and swap MC and MQ so the order remains alphabetical

README.md Outdated Show resolved Hide resolved
@rubiin @WikiRik
Update README.md
3ddd763 
Co-authored-by: Rik Smale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik requested changes

@rubiin rubiin rubiin left review comments

@profnandaa profnandaa Awaiting requested review from profnandaa

@pano9000 pano9000 Awaiting requested review from pano9000

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theos0x @rubiin @WikiRik