Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete RewardValue unit tests #1456

Open
wants to merge 8 commits into
base: flow
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/main/java/RewardValue.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
public class RewardValue {
private double cashValue;
private double milesValue;
private static final double MILES_TO_CASH_CONVERSION_RATE = 0.0035;

// Constructor for cash value
public RewardValue(double cashValue) {
this.cashValue = cashValue;
this.milesValue = cashValue / MILES_TO_CASH_CONVERSION_RATE;
}

// Constructor for miles value
public RewardValue(int milesValue) {
this.milesValue = milesValue;
this.cashValue = milesValue * MILES_TO_CASH_CONVERSION_RATE;
}

// Get the cash value
public double getCashValue() {
return cashValue;
}

// Get the miles value
public double getMilesValue() {
return milesValue;
}
}
18 changes: 9 additions & 9 deletions src/main/java/RewardsConverter.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@

public class RewardsConverter {
public static void main(String[] args) {
var scanner = new Scanner(System.in);
Scanner scanner = new Scanner(System.in);
System.out.println("Welcome to the Credit Card Rewards Converter!");
System.out.println("Please enter a cash value to convert to airline miles: ");
var input_value = scanner.nextLine();
System.out.println("Please enter a cash value to convert to airline miles:");
String inputValue = scanner.nextLine();
double cashValue;
try {
cashValue = Double.parseDouble(input_value);
cashValue = Double.parseDouble(inputValue);
} catch (NumberFormatException exception) {
System.out.println("Could not parse input value as a double, exiting");
System.out.println("Could not parse input value as a double, exiting.");
return;
}
System.out.println("converting $" + input_value + " to miles");
var rewardsValue = new RewardValue(cashValue);
System.out.println("$" + input_value + " is worth " + rewardsValue.getMilesValue() + " miles");
System.out.println("Converting $" + inputValue + " to miles.");
RewardValue rewardsValue = new RewardValue(cashValue);
System.out.println("$" + inputValue + " is worth " + rewardsValue.getMilesValue() + " miles.");
}
}
}
22 changes: 15 additions & 7 deletions src/test/java/RewardValueTests.java
Original file line number Diff line number Diff line change
@@ -1,30 +1,38 @@
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;

public class RewardValueTests {

@Test
void create_with_cash_value() {
double cashValue = 100;
var rewardValue = new RewardValue(cashValue);
assertEquals(cashValue, rewardValue.getCashValue());
RewardValue rewardValue = new RewardValue(cashValue);
assertEquals(cashValue, rewardValue.getCashValue(), "Cash value should match the input value.");
}

@Test
void create_with_miles_value() {
int milesValue = 10000;
var rewardValue = new RewardValue(milesValue);
assertEquals(milesValue, rewardValue.getMilesValue());
RewardValue rewardValue = new RewardValue(milesValue);
assertEquals(milesValue, rewardValue.getMilesValue(), "Miles value should match the input value.");
}

@Test
void convert_from_cash_to_miles() {
assert false;
double cashValue = 100;
RewardValue rewardValue = new RewardValue(cashValue);
double expectedMiles = cashValue / 0.0035;
assertEquals(expectedMiles, rewardValue.getMilesValue(), "Conversion from cash to miles should be accurate.");
}

@Test
void convert_from_miles_to_cash() {
assert false;
int milesValue = 10000;
RewardValue rewardValue = new RewardValue(milesValue);
double expectedCash = milesValue * 0.0035;
assertEquals(expectedCash, rewardValue.getCashValue(), "Conversion from miles to cash should be accurate.");
}
}