This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
Update purejscarousel.3.0.0.js #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding deepclone for buttons prev and next in destroy function to remove Events Listener.
|
Hello, @Raph33000. Thanks for the feedback and pull request. If there really is a problem with removing the event listener, I think it's better to solve it with removeEventListener. But, it's also important to note that since I used anonymous functions as a callback in addEventListener (I was stupid)), calling removeEventListener without updating addEventListener is not possible. I am not ready to spend time on these corrections yet, but I will gladly accept them from you if you understand what it is about and are ready to make them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding deepclone for buttons prev and next in destroy function to remove Events Listener.
Without this, events keep being fired even if carousel has been destroyed (and created error if carousel is initialised again)