Create UWRT utils package #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmmc88
reviewed
Feb 24, 2022
wmmc88
requested changes
Mar 3, 2022
uwrt_mars_rover_utils/include/uwrt_mars_rover_utils/data_utils.hpp
Outdated
Show resolved
Hide resolved
uwrt_mars_rover_utils/include/uwrt_mars_rover_utils/data_utils.hpp
Outdated
Show resolved
Hide resolved
uwrt_mars_rover_arm/uwrt_mars_rover_arm_hw/compile_commands.json
Outdated
Show resolved
Hide resolved
keyonjerome
commented
Mar 4, 2022
| $<INSTALL_INTERFACE:include> | ||
| ) | ||
|
|
||
| ament_export_targets(${PROJECT_NAME}Targets HAS_LIBRARY_TARGET) |
There was a problem hiding this comment.
@wmmc88 I'm not sure what the Modern CMake replacement is for this ament_export_targets line is but this line seems to be required for this to build.
|
I am going to take a deeper look into these failing checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating uwrt_mars_rover_arm_utils package to reduce duplicate code.
Looking for help with adding the package to uwrt_mars_rover_arm_hw; can't seem figure out what's missing in the CMakeLists.txt file for it to be able to find the utils package from arm_hw.