blockchain, netsync: no more headers-first list #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like ProcessBlock, ProcessBlockHeader now takes in behavior flags which allow it to skip parts of header validation for when the chain is still behind the checkpoints.
We add a chainview of bestHeaders so that we'll be able to keep track of headers separately from the bestChain. This is needed as we're getting headers for new block annoucements instead of invs.
maybeAcceptBlockHeader was missing the chain selection logic that would be needed for handling block annoucements for ones that don't extend the current chain tip. It's now able to determine if a block header extends the chain tip or not and returns a boolean indicating if the given header is on the best chain of headers.
ProcessBlockHeader now returns the isMainChain boolean from maybeAcceptBlockHeader, essentially turning the function into a concurrency safe wrapper around maybeAcceptBlockHeader.
The added exported methods on BlockChain provide access to the block header tip like fetching block hashes and heights from the headers chain.
kcalvinalvin
force-pushed
the
2025-01-21-no-more-headerlist
branch
3 times, most recently
from
13d7723 to
886830a
Compare
the next blocks to download. Instead of having a duplicate list that is separately kept track of, we use the info from blockchain to calculate which blocks we need to download next.
kcalvinalvin
force-pushed
the
2025-01-21-no-more-headerlist
branch
from
886830a to
52dcefd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now accept headers for new block announcements, it's impossible to distinguish between
new block announcements and headers received from ibd in the same code block.
We change the code to rely on
ProcessBlockHeaderfor block header connection and for figuring outbest chain selection instead of a strict "does this blockheader connect to the previous one".
This avoids errors that happens during ibd where a block header is rejected and a peer is banned because
of new header announcements that fail to connect as the node does not have the entire chain of headers yet.