feat(restapi): add task plugin signature analysis endpoint, clients & tests #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype to annotation
jkglasbrenner
requested changes
Feb 14, 2025
There was a problem hiding this comment.
The actual functionality of the inputs and response seem good, so I focused on code style, organization, and parameter naming conventions in my review. There's some places where I provided two options for a name, we can move the discussion into Slack to get more feedback on what the team prefers for these if needed.
|
In addition to my code change requests, when its time to consolidate and rewrite the commit messages, I recommend having a separate commit for adding Andy's signature analysis code and unit tests so that he gets proper authorship/attribution. |
keithmanville
approved these changes
Feb 19, 2025
|
closed with #719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #691.
Remake of #719 as rebase went sideways