Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation constraints to properly deference and key on uri-reference values #2107

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aj-stein-gsa
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa commented Feb 15, 2025

Committer Notes

Closes #2102 and closes #2106.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated the OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the OSCAL-Pages and OSCAL_Reference repositories.

@aj-stein-gsa
Copy link
Contributor Author

Per an update in #2103, I am proposing a more focused change to resolve this issue and that in #2102. I will update the PR text.

If possible, I would appreciate a review from the NIST Team.

@wandmagic
Copy link
Collaborator

nice work! this is true to the intention of the constraints and in line with previous examples self referential links prefixed by a hash.

@wandmagic wandmagic added the bug label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants