Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions to upload Electron packages to GitHub release #698

Closed
wants to merge 6 commits into from

Conversation

j0k3r
Copy link
Contributor

@j0k3r j0k3r commented Oct 20, 2023

Description

Attempt to fix #687

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

@j0k3r
Copy link
Contributor Author

j0k3r commented Oct 20, 2023

@helloanoop it should be almost okay (the build is currently running on PR only but I'll convert it once every thing is ok)

You'll need to define some env var on GitHub (probably here: https://github.com/usebruno/bruno/settings/secrets/actions) to properly sign macOS & Windows build: https://www.electron.build/code-signing

Once thing I can figure out is why the Windows build is totally failing with an unhelpful error ...

https://github.com/usebruno/bruno/actions/runs/6588337648/job/17900365695?pr=698

image

@j0k3r j0k3r changed the title Add GitHub Actions to upload Electron package to GitHub release Add GitHub Actions to upload Electron packages to GitHub release Oct 20, 2023
@j0k3r j0k3r force-pushed the fix/upload-release-package branch from 85ea895 to 1168e2a Compare November 15, 2023 08:26
@manojbaishya
Copy link

manojbaishya commented Dec 23, 2023

Ping @helloanoop @j0k3r, can we please merge this? This is for #541. Thanks!

@j0k3r j0k3r force-pushed the fix/upload-release-package branch from 1168e2a to 656b468 Compare February 27, 2024 16:16
@helloanoop
Copy link
Contributor

Thank you for taking the time to create and submit this PR @j0k3r !

We have an internal process in place that generates a build, which then undergoes testing for a few days before being uploaded to GitHub releases.

Closing this PR, as it doesn't align with our current workflow.

@helloanoop helloanoop closed this Sep 4, 2024
@j0k3r j0k3r deleted the fix/upload-release-package branch September 4, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPM Build Github Action
3 participants