-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for sendRequest functionality #3845
Open
pooja-bruno
wants to merge
10
commits into
usebruno:main
Choose a base branch
from
pooja-bruno:feat/support-for-Support-for-sendRequest-functionality
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3e81e03
feat: support for sendRequest functionality
pooja-bruno 9a908d7
cleanup
pooja-bruno e4f3f05
add: sendRequest for safe mode
pooja-bruno 46bd9af
add: sendRequest in hintWords and created bru file for each method
pooja-bruno a2cbd90
Merge branch 'main' into feat/support-for-Support-for-sendRequest-fun…
pooja-bruno 9a7170f
add: basic auth and mode in sendRequest
pooja-bruno aac3ca9
add: digest auth for sendRequest
pooja-bruno 866592b
add: test files for sendRequest
pooja-bruno 7023a22
fixes
pooja-bruno 9efa799
fixes
pooja-bruno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to send the request and pass a specific variable to be used in either the
pre
orpost
scripts?For instance, I'd like to call
bru.sendRequest('./items/delete-item', { itemId: myCustomItemId })
. This would allow developers to customize further their scripts by replacing "request-scoped" variablesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thiagomini Bruno provides an API,
bruno.runRequest('items/delete-item')
, to trigger another request already defined in Bruno.The
sendRequest()
API, on the other hand, is used for making direct HTTP requests.It seems logical to support passing variables when using
sendRequest()
. Could you please create a new GitHub issue outlining this requirement?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see @helloanoop , thanks for the info! So, my idea is actually related to passing variables using the
bruno.runRequest
, do we have that? If not, I'll create an issue asking for that featureThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thiagomini Currently
bruno.runRequest()
does not support passing variables. Please create an issue for the same