add: draft for collection and folder #3740
Open
+564
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooja-bruno
changed the title
helloanoop
reviewed
Jan 7, 2025
packages/bruno-app/src/components/CollectionSettings/Docs/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/FolderSettings/Documentation/index.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/components/FolderSettings/Documentation/index.js
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,71 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
I see there is a lot of repetition across ConfirmCollectionClose , ConfirmFolderClose, and ConfirRequestClose`
This is fine. Lets not try to modularise this.
A good read - https://overreacted.io/the-wet-codebase/
packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
Outdated
Show resolved
Hide resolved
packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
Outdated
Show resolved
Hide resolved
|
@pooja-bruno please check why the CLI tests are failing. I also left a few minor comments related to unused variables. @lohit-bruno PR is quite large, but it looks good to me. Code structure and changes are approved from my side for the merge. I haven't tested it on my laptop. Please test it thoroughly before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding draft logic for collection/folder level setting
Contribution Checklist:
Screen.Recording.2025-01-07.at.11.13.46.AM.mov