Feature/add raw file request body option #2755
Open
+234
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n in request dropdown.
…ecting a file to display.
… it can be saved.
|
This PR addresses #2700 |
1 task
|
Hey @zachary-berdell-elliott, thank you for taking the time to implement this feature! Since the PR is quite extensive, we need some time to review and test it. |
|
Hi @sanjai0py, thanks for taking the time to review this PR. It's good to have a second set of eyes on it. Let me know if you observe any issues with it. I'm willing to make corrections. |
N-Ziermann
reviewed
Aug 14, 2024
…thub.com/zachary-berdell-elliott/bruno into feature/add-raw-file-request-body-option
sanjai0py
reviewed
Aug 26, 2024
packages/bruno-app/src/components/RequestPane/RawFileParams/index.js
Outdated
Show resolved
Hide resolved
…dex.js Co-authored-by: Sanjai Kumar <[email protected]>
Co-authored-by: Sanjai Kumar <[email protected]>
Co-authored-by: Sanjai Kumar <[email protected]>
Co-authored-by: Sanjai Kumar <[email protected]>
|
Hi @sanjai0py, Just committed all your suggestions. Good catches there. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability for a user to set a raw file as the request body. A user is able to select the option raw file and send a request this way. Raw file is stored as a string of the file path and fs library is used to get the file from the path then set it to the file.
Not added with this:
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.