feat: emoji reactions #45
Conversation
…lector Signed-off-by: m-doescode <[email protected]>
There was a problem hiding this comment.
thanks for the PR! probably about time I stop putting these features off...
some initial thoughts:
-
would you mind splitting the reaction viewer into its own PR? it'll probably be easier to get done/merged than the emoji picker
-
I'm not too sure about how emoji picking is going to be handled - I might add a general emoji picker first before coming back to this?
-
I will note more generally that, while this specific package might not be the right one, for packages that need patching you can/should use
yarn patchinstead - see.yarn/patches
| onPress={action(() => { | ||
| msg.channel?.havePermission('React') | ||
| ? app.openAddReaction(msg) | ||
| : showToast('You cannot react to this message.'); | ||
| })} |
There was a problem hiding this comment.
it'd probably be better to just hide the button if the user doesn't have react perms?
There was a problem hiding this comment.
Agreed. I'll wrap it in a ternary checking for permission, then.
| <Text>Add Reaction</Text> | ||
| </ContextButton> | ||
| ) : null} | ||
| {message.channel?.havePermission('SendMessage') && settings.get('ui.messaging.showReactions') ? ( |
There was a problem hiding this comment.
I think you added this check in the wrong place
There was a problem hiding this comment.
Added what in the wrong place, do you mean the button?
There was a problem hiding this comment.
the settings check - you're checking whether reactions are enabled for the reply button instead of the reactions button (the settings check should be on line 59)
m-doescode
force-pushed
the
feature/emoji-reactions
branch
from
a43b679 to
fb7cb63
Compare
|
Thanks for getting back!
Sure thing. Just undid the commits on this PR, will be opening a new one soon.
Probably a good idea. I'm not too pleased with the library I've imported anyway, and it doesn't let you add custom emojis.
Noted. Thanks! |
m-doescode
force-pushed
the
feature/emoji-reactions
branch
2 times, most recently
from
4cf6977 to
65e0613
Compare
m-doescode
force-pushed
the
feature/emoji-reactions
branch
from
65e0613 to
8230945
Compare
Adds a button to the hold-tap message menu which opens up a modal to add reactions.
Also adds an add reaction button next to existing reactions under messages.
There is still some work to be done, namely adding reaction buttons in other places (for instance, while previewing images).
I also don't really like the emoji selector package I've chosen, for one because it feels a bit out of place, but additionally because it doesn't work out-of-the-box and requires patching, which loops in an additional dependency (patch-package) which is not ideal.
Also, the picker does not support custom emojis which will be a problem in the future.
Anyway, this is only a draft and sort of request-for-comments from the maintainers of the project. If you have any suggestions or ideas, please feel free to let me know.
I apologize in advance for any bad code styling/formatting. Let me know and I'll clean it up
Future tasklist:
Please make sure to check the following tasks before opening and submitting a PR