Skip to content

Commit

Permalink
Version 3.3.2 (#123)
Browse files Browse the repository at this point in the history
* Copy Rails config to Ruby

* Update gem links

* Config for better documentation

* Make specs pass with any ENV values

* Update the Changelog
  • Loading branch information
kraft001 authored Mar 26, 2023
1 parent 3003d25 commit 4afbb15
Show file tree
Hide file tree
Showing 8 changed files with 43 additions and 8 deletions.
6 changes: 0 additions & 6 deletions .travis.yml

This file was deleted.

5 changes: 5 additions & 0 deletions .yardopts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
--readme README.md
--title 'Uploadcare Rails API Documentation'
--charset utf-8
--markup markdown
'lib/**/*.rb' - '*.md'
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
The format is based now on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## 3.3.2 — 2023-03-26

### Changed

* Fixed an issue with the configuration
* Updated the gem documentation

## 3.3.1 — 2023-03-20

* Update gem description
Expand Down
9 changes: 9 additions & 0 deletions lib/uploadcare-rails.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ module Rails

def configure
yield configuration
overwrite_ruby_config
end

def overwrite_ruby_config
# copy Rails config to Ruby config
%i[public_key secret_key].each do |param_name|
value = configuration.public_send(param_name)
Uploadcare.config[param_name] = value unless value.nil?
end
end

def configuration
Expand Down
2 changes: 1 addition & 1 deletion lib/uploadcare/rails/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module Uploadcare
module Rails
VERSION = '3.3.1'
VERSION = '3.3.2'
end
end
7 changes: 7 additions & 0 deletions spec/uploadcare/rails/api/rest/group_api_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ module Rest
RSpec.describe GroupApi do
subject { Uploadcare::GroupApi }

around do |example|
previous_value = Uploadcare.config.public_key
Uploadcare.config.public_key = 'demopublickey'
example.run
Uploadcare.config.public_key = previous_value
end

context 'when checking methods' do
it 'responds to expected REST methods' do
%i[get_groups get_group store_group create_group].each do |method|
Expand Down
12 changes: 12 additions & 0 deletions spec/uploadcare/rails_spec.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,19 @@
# frozen_string_literal: true

require 'uploadcare-rails'

RSpec.describe Uploadcare::Rails do
it 'has a version number' do
expect(Uploadcare::Rails::VERSION).not_to be nil
end

it 'overwrites ruby config' do
Uploadcare::Rails.configure do |config|
config.public_key = 'rails_public_key'
config.secret_key = 'rails_secret_key'
end

expect(Uploadcare.config.public_key).to eq 'rails_public_key'
expect(Uploadcare.config.secret_key).to eq 'rails_secret_key'
end
end
3 changes: 2 additions & 1 deletion uploadcare-rails.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ Gem::Specification.new do |gem|
DESCRIPTION
gem.metadata = {
'github' => 'https://github.com/uploadcare/uploadcare-rails',
'issue_tracker' => 'https://github.com/uploadcare/uploadcare-rails/issues',
'bug_tracker_uri' => 'https://github.com/uploadcare/uploadcare-rails/issues',
'changelog_uri' => 'https://github.com/uploadcare/uploadcare-rails/blob/main/CHANGELOG.md',
'rubygems_mfa_required' => 'true'
}
gem.homepage = 'https://github.com/uploadcare/uploadcare-rails'
Expand Down

0 comments on commit 4afbb15

Please sign in to comment.