Bootstrap provider-upjet-gcp-beta #1

turkenf · 2024-09-12T11:49:28Z

Description of your changes

This PR bootstraps provider-upjet-gcp-beta. By copying provider-upjet-gcp from this commit, and removing provider-upjet-gcp related folders, files (apis, examples, providers, crds ...). The required configurations were set according to provider-upjet-gcp-beta/provider-gcp-beta. This provider was generated from version 6.2.0 of terraform provider google-beta.

The following resources have also been added to this PR:

ProjectServiceIdentity.cloudplatform.gcp-beta.upbound.io/v1beta1
Cluster.container.gcp-beta.upbound.io/v1beta1 => Due to the update loop, a custom-diff function has been added for the tpu_config.# field.
Cluster.container.gcp-beta.upbound.io/v1beta2

I have:

Read and followed Upbound's contribution process.
Run make reviewable to ensure this PR is ready for review.
~~Added backport release-x.y labels to auto-backport this PR, as appropriate.~~

How has this code been tested

Manually tested with local make run

status:
  atProvider:
    email: [email protected]
    id: projects/official-provider-testing/services/healthcare.googleapis.com
    member: serviceAccount:[email protected]
    project: official-provider-testing
    service: healthcare.googleapis.com
  conditions:
  - lastTransitionTime: "2024-09-12T11:40:35Z"
    reason: Available
    status: "True"
    type: Ready
  - lastTransitionTime: "2024-09-12T11:40:33Z"
    reason: ReconcileSuccess
    status: "True"
    type: Synced
  - lastTransitionTime: "2024-09-12T11:40:35Z"
    reason: Success
    status: "True"
    type: LastAsyncOperation
  - lastTransitionTime: "2024-09-12T11:48:13Z"
    reason: UpToDate
    status: "True"
    type: Test

k get gcp-beta

NAME                                                             SYNCED   READY   EXTERNAL-NAME                                                           AGE
projectserviceidentity.cloudplatform.gcp-beta.upbound.io/hc-sa   True     True    projects/official-provider-testing/services/healthcare.googleapis.com   6m57s

NAME                                                                           AGE     CONFIG-NAME   RESOURCE-KIND            RESOURCE-NAME
providerconfigusage.gcp-beta.upbound.io/b5aaa2c5-32cf-421b-8feb-c8d3df72a681   6m57s   default       ProjectServiceIdentity   hc-sa

Uptest run: https://github.com/upbound/provider-upjet-gcp-beta/actions/runs/10850559058

Signed-off-by: Fatih Türken <[email protected]>

turkenf · 2024-09-13T14:03:02Z

/test-examples="examples/cloudplatform/v1beta1/projectserviceidentity.yaml"

https://github.com/upbound/provider-upjet-gcp-beta/actions/runs/10850559058

turkenf · 2024-09-13T16:59:26Z

/test-examples="examples/container/v1beta1/cluster.yaml"

Signed-off-by: Fatih Türken <[email protected]>

turkenf · 2024-09-18T12:16:16Z

/test-examples="examples/container/v1beta1/cluster.yaml"

https://github.com/upbound/provider-upjet-gcp-beta/actions/runs/10921913790

turkenf · 2024-09-18T12:16:30Z

/test-examples="examples/container/v1beta2/cluster.yaml"

https://github.com/upbound/provider-upjet-gcp-beta/actions/runs/10921916934

turkenf · 2024-09-18T13:49:04Z

Please ignore report-breaking-changes job. This is caused by the lack of config/schema.json in the main branch.

turkenf · 2024-09-18T13:53:17Z

/test-examples="examples/cloudplatform/v1beta1/projectserviceidentity.yaml"

https://github.com/upbound/provider-upjet-gcp-beta/actions/runs/10923613747

sergenyalcin

Thank you @turkenf for bootstrapping this repository. I left a few comments for your consideration.

sergenyalcin · 2024-09-19T08:50:33Z

build/.gitignore

It seems that the build folder was not added to the repo as a git submodule. We should not copy this folder to this new repo and add this as a git submodule. So, here we need to see also a commit ID reference for the crossplane/build. Then we need to remove this folder and add it as a submodule.

sergenyalcin · 2024-09-19T08:52:29Z

cmd/provider/monolith/zz_main.go

Because of dropping the monolith support, what about not generating the monolith provider?

Would we still generate monolith provider when we wanted to provide an easy-to-install provider image, as in crossplane-contrib/provider-upjet-azure#816 (comment)?

sergenyalcin · 2024-09-19T08:55:04Z

config/provider.go

+	oldSingletonListAPIs string
+)
+
+var skipList = []string{


I am not sure this comment but do we need still this list?

I thought that having this list copied from provider-upjet-gcp might future-proof against potential problems while adding new resources.

Yeah, that's why I didn't remove it.

sergenyalcin · 2024-09-19T08:57:01Z

docs/family/Configuration.md

+
+# Configuration
+
+## Install the provider-family-gcp


Should we update this provider-family-gcp to provider-family-gcp-beta?

sergenyalcin · 2024-09-19T08:58:14Z

docs/family/Development.md

+
+# Building the Official Provider Family Images Locally
+
+1. Check out the provider repo, crossplane-contrib/provider-upjet-gcp, and go to the project


Suggested change

1. Check out the provider repo, crossplane-contrib/provider-upjet-gcp, and go to the project

1. Check out the provider repo, upbound/provider-upjet-gcp-beta, and go to the project

Removed the development guide.

sergenyalcin · 2024-09-19T08:59:02Z

docs/family/Development.md

+# Building the Official Provider Family Images Locally
+
+1. Check out the provider repo, crossplane-contrib/provider-upjet-gcp, and go to the project
+   directory on your local machine.


Will this publish in marketplace? In this situation, because of this repo is private, we may consider publishing this doc.

I guess you mean not publishing; if this is the case, you are right. We should not publish this guide due to this is a private repo. Removed the guide, otherwise, I can add.

sergenyalcin · 2024-09-19T08:59:26Z

docs/family/Quickstart.md

+
+# Quickstart
+
+This guide walks through the process to install Upbound Universal Crossplane and install the GCP official provider-family.


Suggested change

This guide walks through the process to install Upbound Universal Crossplane and install the GCP official provider-family.

This guide walks through the process to install Upbound Universal Crossplane and install the GCP-beta official provider-family.

mergenci · 2024-09-19T10:45:20Z

Thanks @turkenf. I've replied to some of Sergen's comments above. LGTM.

Signed-off-by: Fatih Türken <[email protected]>

turkenf · 2024-09-19T13:03:34Z

/test-examples="examples/cloudplatform/v1beta1/projectserviceidentity.yaml"

turkenf · 2024-09-19T13:03:38Z

/test-examples="examples/container/v1beta2/cluster.yaml"

turkenf · 2024-09-19T13:03:43Z

/test-examples="examples/container/v1beta1/cluster.yaml"

mergenci

Let's move ahead and fix issues, if any, as they come up.

Bootstrap provider-upjet-gcp-beta

c942b55

Signed-off-by: Fatih Türken <[email protected]>

turkenf force-pushed the bootstrap branch from 676a76b to c942b55 Compare September 13, 2024 12:37

turkenf added 2 commits September 13, 2024 16:31

Fix lint issue

f9a91e5

Signed-off-by: Fatih Türken <[email protected]>

Fix build issue

4b018bb

Signed-off-by: Fatih Türken <[email protected]>

Add the v1beta1 version of cluster resource with list

e1cb090

Signed-off-by: Fatih Türken <[email protected]>

turkenf force-pushed the bootstrap branch from 5a3014e to accad2a Compare September 18, 2024 12:15

Add the v1beta2 version of cluster resource with object

2e733f4

Signed-off-by: Fatih Türken <[email protected]>

turkenf force-pushed the bootstrap branch from accad2a to 2e733f4 Compare September 18, 2024 12:16

sergenyalcin reviewed Sep 19, 2024

View reviewed changes

turkenf added 2 commits September 19, 2024 15:43

Add submodule build

8c7312d

Signed-off-by: Fatih Türken <[email protected]>

Address review comments

40c7175

Signed-off-by: Fatih Türken <[email protected]>

mergenci approved these changes Sep 20, 2024

View reviewed changes

jeanduplessis approved these changes Sep 20, 2024

View reviewed changes

turkenf merged commit cfd9e11 into upbound:main Sep 20, 2024
10 of 11 checks passed

turkenf deleted the bootstrap branch September 20, 2024 12:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bootstrap provider-upjet-gcp-beta #1

Bootstrap provider-upjet-gcp-beta #1

turkenf commented Sep 12, 2024 •

edited

Loading

turkenf commented Sep 13, 2024 •

edited

Loading

turkenf commented Sep 13, 2024

turkenf commented Sep 18, 2024 •

edited

Loading

turkenf commented Sep 18, 2024 •

edited

Loading

turkenf commented Sep 18, 2024

turkenf commented Sep 18, 2024 •

edited

Loading

sergenyalcin left a comment

sergenyalcin Sep 19, 2024

turkenf Sep 19, 2024

sergenyalcin Sep 19, 2024

mergenci Sep 19, 2024

sergenyalcin Sep 19, 2024

mergenci Sep 19, 2024

turkenf Sep 19, 2024

sergenyalcin Sep 19, 2024

turkenf Sep 19, 2024

sergenyalcin Sep 19, 2024

turkenf Sep 19, 2024

sergenyalcin Sep 19, 2024

turkenf Sep 19, 2024

sergenyalcin Sep 19, 2024

turkenf Sep 19, 2024

mergenci commented Sep 19, 2024

turkenf commented Sep 19, 2024

turkenf commented Sep 19, 2024

turkenf commented Sep 19, 2024

mergenci left a comment


		# Building the Official Provider Family Images Locally

		1. Check out the provider repo, crossplane-contrib/provider-upjet-gcp, and go to the project

	1. Check out the provider repo, crossplane-contrib/provider-upjet-gcp, and go to the project
	1. Check out the provider repo, upbound/provider-upjet-gcp-beta, and go to the project


		# Quickstart

		This guide walks through the process to install Upbound Universal Crossplane and install the GCP official provider-family.

Bootstrap provider-upjet-gcp-beta #1

Bootstrap provider-upjet-gcp-beta #1

Conversation

turkenf commented Sep 12, 2024 • edited Loading

Description of your changes

How has this code been tested

turkenf commented Sep 13, 2024 • edited Loading

turkenf commented Sep 13, 2024

turkenf commented Sep 18, 2024 • edited Loading

turkenf commented Sep 18, 2024 • edited Loading

turkenf commented Sep 18, 2024

turkenf commented Sep 18, 2024 • edited Loading

sergenyalcin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mergenci commented Sep 19, 2024

turkenf commented Sep 19, 2024

turkenf commented Sep 19, 2024

turkenf commented Sep 19, 2024

mergenci left a comment

Choose a reason for hiding this comment

turkenf commented Sep 12, 2024 •

edited

Loading

turkenf commented Sep 13, 2024 •

edited

Loading

turkenf commented Sep 18, 2024 •

edited

Loading

turkenf commented Sep 18, 2024 •

edited

Loading

turkenf commented Sep 18, 2024 •

edited

Loading