runtime: fix null pointer deference on a window close #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't queue an event to a window after closing it. Move the queue call before we call wclose(). Simplify the code a bit in the process. Signed-off-by: Jafar Al-Gharaibeh <[email protected]>
Don-Ward
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
It's not obvious from the diff listing that the change has the same effect as the original (except fixing the queue event on a closed window bug). But after reading the earlier code -- which sets ws = wb->window; it becomes clearer.
On a personal note, I think
if (expr)
return 1;
is actually worse than if (expr) return 1; but we could argue all day about coding conventions and still get nowhere (and it's not important enough to ask for changes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't queue an event to a window after closing it. Move the queue call before we call wclose().
Simplify the code a bit in the process.