Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix some tests due to moving to Ubuntu 24.04, enable test for Apple silicon and riscv64 #494

Merged
merged 5 commits into from
Dec 21, 2024

Conversation

Jafaral
Copy link
Member

@Jafaral Jafaral commented Dec 12, 2024

No description provided.

Signed-off-by: Jafar Al-Gharaibeh <[email protected]>
@Jafaral Jafaral force-pushed the apple-m branch 3 times, most recently from db0fd0e to d1ea132 Compare December 18, 2024 05:15
@Jafaral Jafaral requested a review from Don-Ward December 18, 2024 05:18
@Jafaral Jafaral force-pushed the apple-m branch 2 times, most recently from bd89242 to 747b778 Compare December 18, 2024 05:42
curtstate = ncp->tstate;
global_curtstate = ncp->tstate;
#endif /* NativeCoswitch */

#endif /* Concurrent */
Copy link
Collaborator

@Don-Ward Don-Ward Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should be /* PthreadCoswitch */

Copy link
Collaborator

@Don-Ward Don-Ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a very minor comment change, looks good. If it's still like that in a few hours, I'll merge it anyway.

Signed-off-by: Jafar Al-Gharaibeh <[email protected]>
@Jafaral
Copy link
Member Author

Jafaral commented Dec 18, 2024

Apart from a very minor comment change, looks good. If it's still like that in a few hours, I'll merge it anyway.

fixings it, and the ci error too.

@Jafaral Jafaral force-pushed the apple-m branch 3 times, most recently from f52aee5 to 2c9642d Compare December 18, 2024 19:12
@Jafaral Jafaral changed the title ci: enable test for Apple silicon ci: fix alpine tests, enable test for Apple silicon and riscv64 Dec 18, 2024
@Jafaral Jafaral changed the title ci: fix alpine tests, enable test for Apple silicon and riscv64 ci: fix some tests due to moving to Ubuntu 24.04, enable test for Apple silicon and riscv64 Dec 18, 2024
@Don-Ward Don-Ward merged commit 5616d36 into uniconproject:master Dec 21, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants