ulsp: move the logger to a separate file #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don-Ward
requested changes
Sep 21, 2024
There was a problem hiding this comment.
I'm guessing that this is in preparation for a future move to a separate library class.
Is it too early to set a good example and put some unidoc descriptions in?
At the very least, we should add
# To do:
# Add unidoc descriptions
# Make the class thread-safe
to the top of the Logger class.
Names of things: I think that there is a potential for an unfortunate confusion in names like debug_class and add_debug_class. Is it a Unicon class we are debugging or adding or a "class" of debug output? It might be better to substitute "category" (or a similar word) for "class".
Jafaral
force-pushed
the
logger
branch
2 times, most recently
from
9d14d8b to
5cd6680
Compare
|
@Don-Ward wish granted |
Signed-off-by: Jafar Al-Gharaibeh <[email protected]>
ValG4
pushed a commit
to ValG4/unicon
that referenced
this pull request
Dec 7, 2024
ulsp: move the logger to a separate file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.