Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatible with vueuse 10.x #29

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix: compatible with vueuse 10.x #29

merged 2 commits into from
Nov 16, 2023

Conversation

aliuq
Copy link
Contributor

@aliuq aliuq commented Nov 14, 2023

Description 描述

vueuse 10.x has removed some of the tool functions. see the discussion

I've used the official repository's method of using typeof judgement directly

Linked Issues 关联的 Issues

Additional context 额外上下文

@ModyQyW
Copy link
Member

ModyQyW commented Nov 15, 2023

Sorry, I am late.

Actually, we can not use @vueuse/core@10 in uni-app because the vue library used by uni-app doesn't export TransitionGroup but @vueuse/core@10 needs it.

image

It is a good idea to remove some tool functions imported from '@vueuse/core'. But we are using typeof too much. Could you please do some organizations? You can put these tool functions into src/utils.ts and use them after importing them. Thanks!

@aliuq
Copy link
Contributor Author

aliuq commented Nov 15, 2023

I just added isString and isFunction to src/utils.ts.

Regarding the upgrade to @vueuse/core@10, the TransitionGroup is actually handled by vue-demi for exports, and in versions prior to vue 3, vue-demi provided the mock function

image

@ModyQyW
Copy link
Member

ModyQyW commented Nov 16, 2023

I just added isString and isFunction to src/utils.ts.

Thanks!

Regarding the upgrade to @vueuse/core@10, the TransitionGroup is actually handled by vue-demi for exports, and in versions prior to vue 3, vue-demi provided the mock function

Thanks for pointing it out! I will double-check the compatibility with vueuse 10.

@ModyQyW
Copy link
Member

ModyQyW commented Nov 16, 2023

Regarding the upgrade to @vueuse/core@10, the TransitionGroup is actually handled by vue-demi for exports, and in versions prior to vue 3, vue-demi provided the mock function

vue-demi only provides the mock function for v2, including v2.7. Since we are targeting v3, we can not use @vueuse/core@10 in uni-app (vue3).

@ModyQyW ModyQyW merged commit 0bc6683 into uni-helper:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants