Skip to content

Commit

Permalink
Fixed some UI issues
Browse files Browse the repository at this point in the history
  • Loading branch information
aritra-tech committed Mar 11, 2024
1 parent 6da609d commit 2e782da
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .idea/deploymentTargetDropDown.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import com.geekymusketeers.uncrack.sharedViewModel.ThemeViewModel
import com.geekymusketeers.uncrack.ui.theme.OnPrimaryContainerLight
import com.geekymusketeers.uncrack.ui.theme.OnSurfaceVariantLight
import com.geekymusketeers.uncrack.ui.theme.SurfaceTintLight
import com.geekymusketeers.uncrack.ui.theme.bold18
import com.geekymusketeers.uncrack.ui.theme.medium14
import com.geekymusketeers.uncrack.ui.theme.medium32
import com.geekymusketeers.uncrack.ui.theme.normal14
Expand Down Expand Up @@ -158,7 +159,7 @@ fun AccountScreen(
}
}

Spacer(modifier = Modifier.height(10.dp))
Spacer(modifier = Modifier.height(40.dp))

LazyColumn(
modifier = Modifier.fillMaxWidth(),
Expand All @@ -169,9 +170,9 @@ fun AccountScreen(
Text(
modifier = Modifier
.fillMaxWidth()
.padding(start = 16.dp, end = 18.dp, bottom = 18.dp),
text = "Security",
style = medium14.copy(color = OnPrimaryContainerLight)
.padding(start = 16.dp, end = 18.dp, top = 18.dp),
text = stringResource(id = R.string.security),
style = bold18.copy(color = OnPrimaryContainerLight)
)
}

Expand All @@ -194,13 +195,13 @@ fun AccountScreen(
Text(
modifier = Modifier
.fillMaxWidth()
.padding(start = 16.dp, end = 18.dp, bottom = 18.dp),
text = "Backup",
style = medium14.copy(color = OnPrimaryContainerLight)
.padding(start = 16.dp, end = 18.dp, top = 18.dp),
text = stringResource(R.string.backup),
style = bold18.copy(color = OnPrimaryContainerLight)
)
}

items(AccountItems.entries.subList(3, AccountItems.entries.size)) {
items(AccountItems.entries.subList(3,5)) {
AccountOption(it) { onClick ->
when(onClick) {
AccountItems.EXPORT_IMPORT -> {}
Expand All @@ -214,13 +215,13 @@ fun AccountScreen(
Text(
modifier = Modifier
.fillMaxWidth()
.padding(start = 16.dp, end = 18.dp, bottom = 18.dp),
text = "General",
style = medium14.copy(color = OnPrimaryContainerLight)
.padding(start = 16.dp, end = 18.dp, top = 18.dp),
text = stringResource(R.string.general),
style = bold18.copy(color = OnPrimaryContainerLight)
)
}

items(AccountItems.entries.subList(3, AccountItems.entries.size)) {
items(AccountItems.entries.subList(5,11)) {
AccountOption(it) { onClick ->
when(onClick) {
AccountItems.THEME -> {
Expand Down Expand Up @@ -272,13 +273,13 @@ fun AccountScreen(
Text(
modifier = Modifier
.fillMaxWidth()
.padding(start = 16.dp, end = 18.dp, bottom = 18.dp),
text = "Danger Zone",
style = medium14.copy(color = OnPrimaryContainerLight)
.padding(start = 16.dp, end = 18.dp, top = 18.dp),
text = stringResource(R.string.danger_zone),
style = bold18.copy(color = OnPrimaryContainerLight)
)
}

items(AccountItems.entries.subList(3, AccountItems.entries.size)) {
items(AccountItems.entries.subList(11, AccountItems.entries.size)) {
AccountOption(it) { onClick ->
when(onClick) {
AccountItems.LOG_OUT -> {
Expand Down
3 changes: 3 additions & 0 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,9 @@
<string name="special_symbols">Special symbols</string>
<string name="include">Include:</string>
<string name="copy">Copy</string>
<string name="backup">Backup</string>
<string name="general">General</string>
<string name="danger_zone">Danger Zone</string>
<string-array name="accounts">
<item>Others</item>
<item>PayPal</item>
Expand Down

0 comments on commit 2e782da

Please sign in to comment.