Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug #18129 #18137

Open
wants to merge 1 commit into
base: contrib
Choose a base branch
from

change base class of ContentFinderByUrlAndTemplate to ContentFinderBy…

d010b7e
Select commit
Loading
Failed to load commit list.
Open

Fix for bug #18129 #18137

change base class of ContentFinderByUrlAndTemplate to ContentFinderBy…
d010b7e
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (contrib) succeeded Jan 27, 2025 in 47s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.30 (9.51 -> 9.21)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Constructor Over-Injection ContentFinderByUrlAndTemplate.cs: ContentFinderByUrlAndTemplate

Annotations

Check warning on line 49 in src/Umbraco.Core/Routing/ContentFinderByUrlAndTemplate.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

❌ New issue: Constructor Over-Injection 

ContentFinderByUrlAndTemplate has 7 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
View more details on CodeScene Delta Analysis