Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create .ubiquibot-config.yml #89

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Sep 13, 2024

This PR enables gnosis UUSD payouts for current repository.

As far as I understand, repo wide config overrides org wide one. (@gentlementlegen pls correct me if I'm wrong)

Wiki: https://github.com/ubiquity/ubiquity-dollar/wiki/24.-Smart-Contracts

@rndquu rndquu requested a review from 0x4007 as a code owner September 13, 2024 15:30
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Sep 13, 2024

@gentlementlegen
Copy link
Member

The it correct. Currently it is totally overridden. There is a related PR here: ubiquity-os/ubiquity-os-kernel#54

@0x4007
Copy link
Member

0x4007 commented Sep 13, 2024

This PR enables ethereum mainnet UUSD payouts for current repository.

Let's do the Gnosis Chain UUSD for now.

@rndquu
Copy link
Member Author

rndquu commented Sep 13, 2024

This PR enables ethereum mainnet UUSD payouts for current repository.

Let's do the Gnosis Chain UUSD for now.

Updated 91dc9ec

@rndquu
Copy link
Member Author

rndquu commented Sep 13, 2024

The it correct. Currently it is totally overridden. There is a related PR here: ubiquity/ubiquibot-kernel#54

You mean "totally overriden" per plugin, right? So this config will inherit, let's say, wallet plugin from org wide config.

@gentlementlegen
Copy link
Member

gentlementlegen commented Sep 14, 2024

@rndquu No totally overridden because after changing the shape using the manifest there is no way to know what to keep and what to remove. We should introduce identifiers to know what to keep and what to remove. You can discuss on the spec ubiquity-os/ubiquity-os-kernel#54 if needed. But basically the problem is that right now the configuration is just and array of plugins that can come in any order, and can all have unique chains, hence the problem.

TL;DR for now copy paste the whole configuration and change what you need, this will be fixed in the kernel soon.

@0x4007
Copy link
Member

0x4007 commented Sep 14, 2024

I think that means I need to generate another repository specific evm key encrypted, right @rndquu ?

@rndquu
Copy link
Member Author

rndquu commented Sep 14, 2024

I think that means I need to generate another repository specific evm key encrypted, right @rndquu ?

No, current private key setup (PRIVATE_KEY:GITHUB_ORGANIZATION_ID) will work fine for individual repositories.

Ok, I've copy/pasted the whole config so it seems to be good to merge now.

@ubiquity-os ubiquity-os bot merged commit be6673d into development Sep 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants