Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix husky #95

Open
wants to merge 12 commits into
base: development
Choose a base branch
from
Open

Fix husky #95

wants to merge 12 commits into from

Conversation

zugdev
Copy link
Contributor

@zugdev zugdev commented Feb 11, 2025

Resolves #94

Changes:

  • Removed deprecated husky install and prepare script from package.json
  • Removed the following deprecated code blocks from husky hooks, those will fail soon in v10.0.0
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

QA:

  • passing case:
ts-template % echo "feat: add new feature" | yarn commitlint

yarn run v1.22.22
$ ./ts-template/node_modules/.bin/commitlint
✨  Done in 0.75s.
  • non passing case (missing colon)
ts-template % echo "feat add new feature" | yarn commitlint

yarn run v1.22.22
$ ./ts-template/node_modules/.bin/commitlint
⧗   input: feat add new feature
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
  • non passing case (wrong type)
ts-template % echo "add: add new feature" | yarn commitlint

yarn run v1.22.22
$ ./ts-template/node_modules/.bin/commitlint
⧗   input: add: add new feature
✖   type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

How to QA and setup:

  1. yarn install
  2. you can: echo "string_you_want_to_test" | yarn commitlint
  3. or compare against old commits: yarn commitlint --from HEAD~1 --to HEAD
  4. for stage linter you can just run yarn lint-staged with staged files

Copy link

ubiquity-os bot commented Feb 11, 2025

Caution

[universal-github-app-jwt] Private Key is in PKCS#1 format, but only PKCS#8 is supported. See https://github.com/gr2m/universal-github-app-jwt#private-key-formats

@zugdev zugdev requested a review from 0x4007 February 11, 2025 18:19
@zugdev
Copy link
Contributor Author

zugdev commented Feb 11, 2025

Caution

[universal-github-app-jwt] Private Key is in PKCS#1 format, but only PKCS#8 is supported. See https://github.com/gr2m/universal-github-app-jwt#private-key-formats

@0x4007 @gentlementlegen

@0x4007
Copy link
Member

0x4007 commented Feb 11, 2025

Can you ensure this works with bun cause we are trying to fully migrate to it.

Copy link
Contributor

Unused devDependencies (1)

Filename devDependencies
package.json husky

.husky/commit-msg Outdated Show resolved Hide resolved
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Feb 11, 2025

@0x4007
Copy link
Member

0x4007 commented Feb 11, 2025

Caution

[universal-github-app-jwt] Private Key is in PKCS#1 format, but only PKCS#8 is supported. See https://github.com/gr2m/universal-github-app-jwt#private-key-formats

@0x4007 @gentlementlegen

Yes we have been seeing this more lately in the last few days. I'm not sure we have a root cause analysis ready yet.

@github-actions github-actions bot deleted a comment from 0x4007 Feb 11, 2025
@zugdev zugdev requested a review from 0x4007 February 11, 2025 23:21
@0x4007
Copy link
Member

0x4007 commented Feb 12, 2025

It says GitHub actions deleted a comment from me. What's that about

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should do

bun run x

Without run I've had problems. With run no problems

package.json Outdated Show resolved Hide resolved
@gentlementlegen
Copy link
Member

This would also apply to https://github.com/ubiquity-os/plugin-template

Co-authored-by: アレクサンダー.eth <[email protected]>
package.json Outdated Show resolved Hide resolved
@zugdev zugdev requested a review from 0x4007 February 13, 2025 20:28
@zugdev
Copy link
Contributor Author

zugdev commented Feb 14, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

husky pre-commit hook implementation will be deprecated
3 participants