-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/polymorphic tests #15
Refactor/polymorphic tests #15
Conversation
the jest workflow shouldn't run |
97140c3
to
5f7b03f
Compare
CI is failing here because it's using workflows from Testing it myself my CI keeps throwing this below but as you can see above all test cases are passing, I just need to figure out why my CI seems to be busted. Lots of related gh issues for it, tried a fair few solutions to no avail, yet. |
The code above produces this error:
Pls fix |
You should only need to fill in the required config props and your golden. I fresh installed, tried both build envs with your script and with const config: HandlerConstructorConfig = {
networkId: 1,
rpcTimeout: 1500,
autoStorage: false,
cacheRefreshCycles: 10,
networkName: null,
networkRpcs: null,
runtimeRpcs: null,
}; |
@Keyrxng Why did you remove |
because of the CI errors I was having seeing as the fresh lock didn't change anything and typically no lock is committed. Think it's best to add it back? |
build: add yarn.lock
@Keyrxng Could you describe the main code changes of this exact PR and provide a time estimate for it? |
time 2-4 hrs The task I'd say is making the package polymorphic, the latency and timeout fix happening over the course of review. Tests needed refactored because of how the way the build output was changed in improving exports. |
Pls self assign #16 |
Resolves #16
Split from #6
Required by #14