Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multichain permit2 allowance UI #1

Open
wants to merge 147 commits into
base: development
Choose a base branch
from

Conversation

zugdev
Copy link

@zugdev zugdev commented Feb 3, 2025

Resolves ubiquity/onboard.ubq.fi#29

QA:

approval-demo.mov

How to QA and setup:
1.yarn install

  1. yarn test:anvil

  2. Open new terminal and yarn start (keep anvil alive)

  3. Select anvil as the network in the UI

molecula451 and others added 30 commits February 29, 2024 23:39
* chore: push everything including commits

* chore: update lib

* chore: update lib

* chore: update

* chore: update

* chore: update

* chore: update

* chore: update deploy

* chore: please knip
* chore: push everything including commits

* chore: update lib

* chore: update lib

* chore: update

* chore: update

* chore: update

* chore: update

* chore: update deploy

* chore: please knip

* fix: updated ubiquibot package and removed submodule

* fix: the remote config now comes from the package and not a fetch

---------

Co-authored-by: molecula451 <[email protected]>
feat: added instructions and Cypress test
fix: cypress now defaults to chrome for testing in the Action file
@rndquu rndquu marked this pull request as ready for review February 7, 2025 14:05
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@rndquu
Copy link
Member

rndquu commented Feb 7, 2025

RPC call failed, I will improve messaging

Somehow llamarpc provider works only with VPN enabled :(

Copy link

ubiquity-os bot commented Feb 8, 2025

@zugdev, this task has been idle for a while. Please provide an update.

@zugdev
Copy link
Author

zugdev commented Feb 8, 2025

I take back what I said about using Alchemy. @ubiquity-dao/rpc-handler is super sick, works great, will use it everywhere.

pls give it a spin, it should work flawlessly now :) nice one @0x4007

@zugdev zugdev requested a review from rndquu February 8, 2025 19:44
Copy link

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the CI passes

static/constants.ts Outdated Show resolved Hide resolved
static/display-popup-modal.ts Outdated Show resolved Hide resolved
static/display-popup-modal.ts Outdated Show resolved Hide resolved
static/handle-approval.ts Outdated Show resolved Hide resolved
static/main.ts Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
Copy link

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knip still fails

.husky/pre-commit Outdated Show resolved Hide resolved
.husky/commit-msg Outdated Show resolved Hide resolved
static/handle-approval.ts Show resolved Hide resolved
static/main.ts Outdated Show resolved Hide resolved
@zugdev
Copy link
Author

zugdev commented Feb 11, 2025

@whilefoo thanks for the quick reviews, should be gtg, lmk otherwise

@zugdev zugdev requested a review from whilefoo February 11, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add permit2 approval
8 participants