-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI refac #375
base: development
Are you sure you want to change the base?
UI refac #375
Conversation
Unused exports (1)
|
|
Looks good but not sure about the drawer on the bottom. Why not use the same modal tech we already have? I like that it's hands off and disappears after the visible timer expires. Also one thing that has always bothered me but in dark mode the ubiquity logo is not white and matching the text. Please fix the fill. If there is no permit data it should show something. Just checked the QA link at https://5e1f8539.pay-ubq-fi.pages.dev/ |
The drawer contains card mint stuff, it's a little bigger (in content) than modal and its not really temporary. I dont think its the best solution, when rollups are through we will enable arbitrary claiming, therefore a mint card page would make more sense.
Will do.
Gotcha. |
Having second thoughts on permit rollups if the UI will automatically fetch all the unclaimed permits from the previous month. Permit rollups have been in proposal stage for like a year with still no traction. However my proposal on fetching and importing the unclaimed permits seems pretty straightforward to implement without security concerns. |
Yeah, I think both are fine. The biggest problem for me are forgotten permits, when I forget to claim, so fetching all pending ones is a straight forward solution. It also reduces the complexity of voiding an existing permit from an admin pov, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
error toaster is behind the card section. making toaster invisible. I had to tweak opacity to find it.
-
can you hide/close the card section once opened? I think the drag handler is for that? It doesn't seem to work with mouse. probably z-index issue.
-
similarly problem with redeem card section. Reveal button is under another element.
@zugdev i thought you got rid of the unnecessary pictures of the cards |
@zugdev, this task has been idle for a while. Please provide an update. |
Resolves #356
also resolves all other UI open issues in the repo. #344 #312 #237
Screen.Recording.2025-01-30.at.16.24.04.mov
Fixes header and footer.
Fixes addresses and ens ellipsis.
Here is a quick demo in dark mode:
Screen.Recording.2025-01-30.at.16.27.05.mov
Here is a quick demo in light mode:
Screen.Recording.2025-01-30.at.16.27.52.mov