Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI refac #375

Draft
wants to merge 21 commits into
base: development
Choose a base branch
from
Draft

UI refac #375

wants to merge 21 commits into from

Conversation

zugdev
Copy link
Contributor

@zugdev zugdev commented Jan 30, 2025

Resolves #356

also resolves all other UI open issues in the repo. #344 #312 #237

  1. Adds a shimmer effect instead of loading:
Screen.Recording.2025-01-30.at.16.24.04.mov
  1. Quit table approach, use flex boxes for layouting.
Screenshot 2025-01-30 at 16 24 39
  1. Fixes header and footer.

  2. Fixes addresses and ens ellipsis.

Screenshot 2025-01-30 at 16 29 54 image
  1. Contains debit card stuff into a modal.

Here is a quick demo in dark mode:

Screen.Recording.2025-01-30.at.16.27.05.mov

Here is a quick demo in light mode:

Screen.Recording.2025-01-30.at.16.27.52.mov

@zugdev zugdev requested a review from 0x4007 January 30, 2025 19:40
Copy link
Contributor

Unused exports (1)

Filename exports
static/scripts/rewards/button-controller.ts getCardContainer

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Jan 30, 2025

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Preview Deployment
97b81f1fbc8182d3890996be203fcb98b6820c01

@0x4007
Copy link
Member

0x4007 commented Feb 1, 2025

Looks good but not sure about the drawer on the bottom. Why not use the same modal tech we already have? I like that it's hands off and disappears after the visible timer expires.

Also one thing that has always bothered me but in dark mode the ubiquity logo is not white and matching the text. Please fix the fill.

If there is no permit data it should show something. Just checked the QA link at https://5e1f8539.pay-ubq-fi.pages.dev/

@zugdev
Copy link
Contributor Author

zugdev commented Feb 1, 2025

Looks good but not sure about the drawer on the bottom. Why not use the same modal tech we already have? I like that it's hands off and disappears after the visible timer expires.

The drawer contains card mint stuff, it's a little bigger (in content) than modal and its not really temporary. I dont think its the best solution, when rollups are through we will enable arbitrary claiming, therefore a mint card page would make more sense.

Also one thing that has always bothered me but in dark mode the ubiquity logo is not white and matching the text. Please fix the fill.

Will do.

If there is no permit data it should show something.

Gotcha.

@0x4007
Copy link
Member

0x4007 commented Feb 5, 2025

when rollups are through

Having second thoughts on permit rollups if the UI will automatically fetch all the unclaimed permits from the previous month.

Permit rollups have been in proposal stage for like a year with still no traction. However my proposal on fetching and importing the unclaimed permits seems pretty straightforward to implement without security concerns.

@zugdev
Copy link
Contributor Author

zugdev commented Feb 5, 2025

when rollups are through

Having second thoughts on permit rollups if the UI will automatically fetch all the unclaimed permits from the previous month.

Permit rollups have been in proposal stage for like a year with still no traction. However my proposal on fetching and importing the unclaimed permits seems pretty straightforward to implement without security concerns.

Yeah, I think both are fine. The biggest problem for me are forgotten permits, when I forget to claim, so fetching all pending ones is a straight forward solution. It also reduces the complexity of voiding an existing permit from an admin pov,

Copy link
Contributor

@EresDev EresDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fix word-break: break-all;
    image

  • payment card section needs work.
    image

  • error toaster is behind the card section. making toaster invisible. I had to tweak opacity to find it.
    image

  • can you hide/close the card section once opened? I think the drag handler is for that? It doesn't seem to work with mouse. probably z-index issue.

  • similarly problem with redeem card section. Reveal button is under another element.
    image

@0x4007
Copy link
Member

0x4007 commented Feb 12, 2025

@zugdev i thought you got rid of the unnecessary pictures of the cards

Copy link
Contributor

ubiquity-os bot commented Feb 13, 2025

@zugdev, this task has been idle for a while. Please provide an update.

@ubiquity-os ubiquity-os bot marked this pull request as draft February 13, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor pay.ubq.fi and quit table approach
3 participants