Fix/view claim #251
Fix/view claim #251
Conversation
| @@ -100,12 +100,17 @@ async function transferFromPermit(permit2Contract: Contract, app: AppState) { | |||
| async function waitForTransaction(tx: TransactionResponse) { | |||
| try { | |||
| const receipt = await tx.wait(); | |||
| viewClaimButton.onclick = () => { | |||
| window.open(`https://${tx.chainId === 1 ? "etherscan" : "gnosisscan"}.io/tx/${receipt.transactionHash}`, "_blank"); | |||
There was a problem hiding this comment.
Seems like a bad approach. Why would you only support one or the other if we are supposed to support every EVM chain with a permit2 deployment?
There was a problem hiding this comment.
Good point, the most robust solution I could come up with is to use Blockscan. Check the link, it's the Permit2 address and on the left hand side there is a dropdown of the chains that are supported (26).
The reason why I've used this approach over building our own dataset of chain explorers as that's what we'd need to do is because they don't share a uniform URL schema so we'd need to manually collect chains that either we'd allow support for or just a more robust collection than what Blockscan currently has.
There was a problem hiding this comment.
Manually collect seems fine. I recall like eight networks some of which are test networks.
I can't find the table of networks from my phone but check the uniswap docs.
There was a problem hiding this comment.
List of supported chains through blockscan
There was a problem hiding this comment.
Best to open an issue in rpc-handler to update the network explorers and then use that as a single source across projects then
that is a solid list for mainnets, do you have any other specific chains in mind that are not included here?
I can't find that table you mentioned either but I'll be able to track down the explorers anyway, I'll aim to cover at least mainnet and it's testnet and if it has multiple testnets like ETH, I'll grab the most relevant ones.
There was a problem hiding this comment.
I just quickly looked up where it has activity... Except I'm not 100% sure its deployed on every one of these chains.
https://blockscan.com/address/0x000000000022d473030f116ddee9f6b43ac78ba3#portfolios
We should manually test that it works on the main chains, such as: Ethereum mainnet, Optimism, Arbitrum, Polygon, Gnosis, Base
Resolves #250