fix: move controls into sight #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4007
reviewed
Jun 11, 2024
| @@ -63,6 +63,7 @@ export async function renderTransaction(): Promise<Success> { | |||
| } else { | |||
| const requestedAmountElement = insertErc721PermitTableData(app.reward, table); | |||
| table.setAttribute(`data-make-claim`, "ok"); | |||
| table.setAttribute(`data-additional-data-size`, "large"); | |||
There was a problem hiding this comment.
Where is the logic to remove this? If this is to display on NFT rewards, what happens when you switch to a non NFT reward? Does it re-render the table without this attribute?
There was a problem hiding this comment.
This scenario never dawned on me but it does not re-render the table. I crafted a permit with both types in it NFT first and it shifted for ERC20.
0x4007
reviewed
Jun 11, 2024
Actually I think it's a bad idea to move the interaction elements (the view details button) You should only render the details higher and maintain the position of the button. It's unnecessary extra work for the user to move their mouse and chase the button. |
move-table-up.mp4When is it expected that NFT permits will start getting printed? |
0x4007
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #247
The add. table is well placed and it didn't feel right moving it up any further
transformand movesmainTableBodyinto sight only for NFTsBefore:
hidden-controls.mp4
After:
show-controls.mp4