Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cosmetic enhancements #161

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Feb 15, 2024

Resolves #155

  • same conditional applied in both init() and renderTransaction()
  • class based CSS for pagination
  • already claimed toast change
  • new PR so commit history is cleaner

Single claim without any pagination:

bandicam.2024-02-15.14-23-06-169.mp4

Multi claim with pagination:

bandicam.2024-02-15.14-22-37-184.mp4

@Keyrxng Keyrxng requested a review from 0x4007 as a code owner February 15, 2024 14:37
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good just a small request

@0x4007
Copy link
Member

0x4007 commented Feb 15, 2024

It says "claim complete receipt transaction hash." Is this due to your spoofing?

Screenshot 2024-02-16 at 01 09 05

@Keyrxng Keyrxng requested a review from rndquu as a code owner February 16, 2024 10:32
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally the ! is not allowed but looks like the linter is out of date on this repository so I'll just merge and address it later.

    prevTxButton!.classList.remove("hide-pagination");
    nextTxButton!.classList.remove("hide-pagination");

    prevTxButton!.classList.add("show-pagination");
    nextTxButton!.classList.add("show-pagination");

@0x4007
Copy link
Member

0x4007 commented Feb 16, 2024

Will merge because I assume you tested it and I'm currently still fixing continuous deployments

@0x4007 0x4007 merged commit bd24f46 into ubiquity:development Feb 16, 2024
1 check passed
@ubiquibot ubiquibot bot mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmetic Enhancements
2 participants